Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rbac proxy deprecation #106

Merged
merged 6 commits into from
Dec 16, 2024
Merged

fix: rbac proxy deprecation #106

merged 6 commits into from
Dec 16, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Dec 1, 2024

Should fix: #105

@csatib02 csatib02 added the enhancement New feature or request label Dec 1, 2024
@csatib02 csatib02 self-assigned this Dec 1, 2024
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
@csatib02 csatib02 force-pushed the fix/rbac-proxy-deprecation branch from e5ed6c4 to 4ea09f1 Compare December 15, 2024 11:41
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
@csatib02 csatib02 force-pushed the fix/rbac-proxy-deprecation branch from 4ea09f1 to a15836f Compare December 15, 2024 11:47
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
@csatib02 csatib02 requested review from pepov and OverOrion December 15, 2024 12:51
@csatib02 csatib02 marked this pull request as ready for review December 15, 2024 12:51
Copy link
Member

@pepov pepov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please verify that non-secure still works? (for debugging for example)

charts/telemetry-controller/templates/deployment.yaml Outdated Show resolved Hide resolved
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
@csatib02 csatib02 requested a review from pepov December 16, 2024 09:25
@csatib02 csatib02 merged commit 82b2849 into main Dec 16, 2024
11 checks passed
@csatib02 csatib02 deleted the fix/rbac-proxy-deprecation branch December 16, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ Action Required: Replace Deprecated gcr.io/kubebuilder/kube-rbac-proxy
3 participants