fix: various issues with API structs #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #26. The problem described in the ticket occurs because the
omitempty
directive in the JSON struct tag instructs theencoding/json
library to omit fields with a "zero value." The zero value depends on the field's type; for structs, the zero value is an initialized but empty struct.Solution:
omitempty
directive omits fields that arenil
, as the zero value for a pointer isnil
.NOTE: The reason why
yaml
marshalling worked, is becuaseyaml
has a different implementation for theomitempty
tag. It treats empty collections (like maps and slices) as well as empty but initialized structs as "omittable," even when non-nil..