Skip to content

Commit

Permalink
chore(deps): follow up for 'GRPCClientSettings, use ClientConfig inst…
Browse files Browse the repository at this point in the history
…ead #9402'

Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
  • Loading branch information
OverOrion committed Feb 13, 2024
1 parent e9ff5a5 commit 7193efd
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 37 deletions.
8 changes: 4 additions & 4 deletions api/telemetry/v1alpha1/oteloutput_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ type OtelOutputSpec struct {

// OTLP grpc exporter config ref: https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/otlpexporter/config.go
type OTLPgrpc struct {
QueueConfig QueueSettings `json:"sending_queue,omitempty" yaml:"sending_queue,omitempty"`
RetryConfig BackOffConfig `json:"retry_on_failure,omitempty" yaml:"retry_on_failure,omitempty"`
TimeoutSettings `json:",inline" yaml:",inline"`
GRPCClientSettings `json:",inline" yaml:",inline"`
QueueConfig QueueSettings `json:"sending_queue,omitempty" yaml:"sending_queue,omitempty"`
RetryConfig BackOffConfig `json:"retry_on_failure,omitempty" yaml:"retry_on_failure,omitempty"`
TimeoutSettings `json:",inline" yaml:",inline"`
ClientConfig `json:",inline" yaml:",inline"`
}

// OtelOutputStatus defines the observed state of OtelOutput
Expand Down
4 changes: 2 additions & 2 deletions api/telemetry/v1alpha1/otlp_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ type KeepaliveClientConfig struct {
PermitWithoutStream bool `json:"permit_without_stream,omitempty" yaml:"permit_without_stream,omitempty"`
}

// GRPCClientSettings defines common settings for a gRPC client configuration.
type GRPCClientSettings struct {
// ClientConfig defines common settings for a gRPC client configuration.
type ClientConfig struct {
// The target to which the exporter is going to send traces or metrics,
// using the gRPC protocol. The valid syntax is described at
// https://github.com/grpc/grpc/blob/master/doc/naming.md.
Expand Down
58 changes: 29 additions & 29 deletions api/telemetry/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions internal/controller/telemetry/otel_conf_gen_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func TestOtelColConfComplex(t *testing.T) {
},
Spec: v1alpha1.OtelOutputSpec{
OTLP: v1alpha1.OTLPgrpc{
GRPCClientSettings: v1alpha1.GRPCClientSettings{
ClientConfig: v1alpha1.ClientConfig{
Endpoint: "receiver-collector.example-tenant-ns.svc.cluster.local:4317",
TLSSetting: v1alpha1.TLSClientSetting{
Insecure: true,
Expand All @@ -114,7 +114,7 @@ func TestOtelColConfComplex(t *testing.T) {
},
Spec: v1alpha1.OtelOutputSpec{
OTLP: v1alpha1.OTLPgrpc{
GRPCClientSettings: v1alpha1.GRPCClientSettings{
ClientConfig: v1alpha1.ClientConfig{
Endpoint: "receiver-collector.example-tenant-ns.svc.cluster.local:4317",
TLSSetting: v1alpha1.TLSClientSetting{
Insecure: true,
Expand Down

0 comments on commit 7193efd

Please sign in to comment.