Skip to content

Commit

Permalink
fix uninstall order
Browse files Browse the repository at this point in the history
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@gmail.com>
  • Loading branch information
kristofgyuracz committed Feb 5, 2024
1 parent a9c7ab5 commit 63e7a25
Showing 1 changed file with 5 additions and 17 deletions.
22 changes: 5 additions & 17 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,6 @@ kubectl apply -f https://github.com/open-telemetry/opentelemetry-operator/releas
make install
```

**Build and push your image to the location specified by `IMG`:**

```sh
make docker-build docker-push IMG=<some-registry>/telemetry-controller:<tag>
```

> **NOTE:** This image ought to be published in the personal registry you specified.
And it is required to have access to pull the image from the working environment.
Make sure you have the proper permission to the registry if the above commands don’t work.

**OR**

**Build your image and load it to your KinD nodes**
```sh
make docker-build IMG=telemetry-controller:latest
Expand All @@ -46,7 +34,7 @@ kind load docker-image telemetry-controller:latest
**Deploy the Manager to the cluster with the image specified by `IMG`:**

```sh
make deploy IMG=<some-registry>/telemetry-controller:tag
make deploy IMG=telemetry-controller:tag
```

> **NOTE**: If you encounter RBAC errors, you may need to grant yourself cluster-admin
Expand Down Expand Up @@ -91,16 +79,16 @@ helm install --wait --create-namespace --namespace example-tenant-ns --generate-
kubectl delete -f docs/examples/simple-demo/
```

**Delete the APIs(CRDs) from the cluster:**
**UnDeploy the controller from the cluster:**

```sh
make uninstall
make undeploy
```

**UnDeploy the controller from the cluster:**
**Delete the APIs(CRDs) from the cluster:**

```sh
make undeploy
make uninstall
```

## Contributing
Expand Down

0 comments on commit 63e7a25

Please sign in to comment.