Skip to content

Commit

Permalink
remove strict atuhentication checkin
Browse files Browse the repository at this point in the history
  • Loading branch information
tarokkk committed Mar 3, 2020
1 parent c13ecc5 commit 5a80753
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
6 changes: 0 additions & 6 deletions pkg/sdk/model/output/s3.go
Original file line number Diff line number Diff line change
Expand Up @@ -257,11 +257,5 @@ func (c *S3OutputConfig) validateAndSetCredentials(s3 *types.OutputPlugin, secre
s3.SubDirectives = append(s3.SubDirectives, directive)
}
}
if c.AssumeRoleCredentials == nil &&
c.InstanceProfileCredentials == nil &&
c.SharedCredentials == nil &&
(c.AwsAccessKey == nil || c.AwsSecretKey == nil) {
return errors.New("One of AssumeRoleCredentials or SharedCredentials or InstanceProfileCredentials must be configured")
}
return nil
}
8 changes: 0 additions & 8 deletions pkg/sdk/model/render/fluent_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -498,14 +498,6 @@ func TestRenderS3(t *testing.T) {
profile_name f
</shared_credentials>`,
},
{
name: "missing auth",
s3Config: output.S3OutputConfig{
Path: "/var/buffer",
S3Bucket: "test_bucket",
},
err: "One of AssumeRoleCredentials or SharedCredentials or InstanceProfileCredentials must be configured",
},
}
for _, item := range table {
t.Logf("> %s\n", item.name)
Expand Down

0 comments on commit 5a80753

Please sign in to comment.