Skip to content

Commit

Permalink
[pvc-docs] fixing documention for storage PVC configuration (#400)
Browse files Browse the repository at this point in the history
  • Loading branch information
aitorhh authored Oct 12, 2024
1 parent 2fb5470 commit 94c12e8
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
13 changes: 10 additions & 3 deletions docs/modelserving/storage/pvc/pvc.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ Update the ${PVC_NAME} to the created PVC name and create the InferenceService w
model:
modelFormat:
name: sklearn
storageUri: "pvc://${PVC_NAME}/model.joblib"
storageUri: "pvc://${PVC_NAME}/${MODEL_NAME}/"
```

=== "Old Schema"
Expand All @@ -116,16 +116,23 @@ Update the ${PVC_NAME} to the created PVC name and create the InferenceService w
spec:
predictor:
sklearn:
storageUri: "pvc://${PVC_NAME}/model.joblib"
storageUri: "pvc://${PVC_NAME}/${MODEL_NAME}/"
```

Apply the `autoscale-gpu.yaml`.
Apply the `sklearn-pvc.yaml`.

=== "kubectl"
```bash
kubectl apply -f sklearn-pvc.yaml
```

Note that inside the folder `${PVC_NAME}/${MODEL_NAME}/` you should have your
model `model.joblib`.

Note also that `${MODEL_NAME}` is just a folder, but a good convention to keep
the same name.


## Run a prediction

Now, the ingress can be accessed at `${INGRESS_HOST}:${INGRESS_PORT}` or follow [this instruction](../../../get_started/first_isvc.md#4-determine-the-ingress-ip-and-ports)
Expand Down
2 changes: 1 addition & 1 deletion docs/modelserving/storage/pvc/sklearn-pvc-new.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ spec:
model:
modelFormat:
name: sklearn
storageUri: "pvc://${PVC_NAME}/model.joblib"
storageUri: "pvc://${PVC_NAME}/sklearn-pvc"
2 changes: 1 addition & 1 deletion docs/modelserving/storage/pvc/sklearn-pvc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ metadata:
spec:
predictor:
sklearn:
storageUri: "pvc://${PVC_NAME}/model.joblib"
storageUri: "pvc://${PVC_NAME}/sklearn-pvc"

0 comments on commit 94c12e8

Please sign in to comment.