Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OWNERS to have more active reviewers and approvers #80

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

juliusvonkohout
Copy link
Contributor

@juliusvonkohout juliusvonkohout commented Jun 12, 2024

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Copy link
Contributor Author

CC @elikatsis @StefanoFioravanzo

@juliusvonkohout
Copy link
Contributor Author

Related PR #20 @markwinter

@rimolive
Copy link
Contributor

cc @yuzisun

Can you approve?

@yuzisun
Copy link
Member

yuzisun commented Jun 13, 2024

/lgtm
/approve

@rimolive
Copy link
Contributor

/verify-owners

@rimolive
Copy link
Contributor

@yuzisun What is the process to become KServe members? This PR won't be merged if we don't do that.

@rimolive
Copy link
Contributor

/verify-owners

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be automatically merged once you accept the invite.

@rimolive
Copy link
Contributor

Both of us accepted the invites.

@kimwnasptd
Copy link
Contributor

/approve

Glad to see more folks helping! I can manually merge the PR for now as well

Copy link

oss-prow-bot bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout, kimwnasptd, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kimwnasptd kimwnasptd merged commit 8f8feb4 into kserve:master Jun 17, 2024
6 of 7 checks passed
tiansiyuan pushed a commit to vikas-saxena02/models-web-app that referenced this pull request Jun 28, 2024
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants