Add myself to OWNERS #20
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: markwinter The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mark Winter <mark.winter@navercorp.com>
|
@mark I'm definitely up for having more owners to help increasing our velocity. I'd by happy to add you to the approvers, but I'd like to first work a little bit more together with you and have merged some PRs. But lets also try to quantify this, to have a path for someone to be an approver. I believe once someone has 10 PRs merged and have helped with 5 reviews then they could be a added as an approver at this stage of the project. I also understand the argument that this could be difficult if I'm slow with the reviews, and apologies for that. I'll be allocating more cycles for this effort very soon and keep maintaining and contributing to the project. if within the next month I don't manage to handle then lets definitely approve this PR. WDYT? |
|
@kimwnasptd |
|
I am reopening this, @markwinter has been contributing to kserve since early 2021 and recently to the web app, so far seems like we need more owners for the web-app repo, @kimwnasptd can you help reevaluate ? |
|
@yuzisun I'm more than happy to add @markwinter as an approver, since it's evident from his existing work and PRs that he is technically adept and knows the codebase. This will definitely help increase the throughput in this repo. I'll also ensure his current PRs are merged to help getting his existing work in. At the same time lets also start documenting and formalizing the process on how someone could become an approver/reviewer in the repo. Do we have such guidelines for KServe? We could use the same throughout the org. |
|
@kimwnasptd I agree, I think it would be good to have a formal process like that in place (for KServe too). May help foster more community engagement. I'll go back to my current open PRs and fix the lint issues soon (although I'm on holiday next week fyi) |
Sounds good, will work on the doc for approver and reviewer process. |
|
@markwinter please rebase to master |
Signed-off-by: Mark Winter <mark.winter@navercorp.com>
|
@kimwnasptd @rimolive please review. |
|
/lgtm cc @kimwnasptd |
|
/lgtm we need every hand we can get :-D. @kimwnasptd or Ricardo feel free to approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markwinter, rimolive The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@yuzisun Another PR that was not merged because tide says push was not suceeded. Is it something wrong with tide, or we need to do additional steps in here? |
Signed-off-by: Mark Winter <mark.winter@navercorp.com> Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
Currently there is no activity in this repo.
I have a good understanding of the code and am able to make significant updates to it (see my currently open PRs).
So I'm suggesting adding myself as an approver to try and move things along.
@yuzisun @kimwnasptd