Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to bring their own test templating when using KafkaClusterExtension #249

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Allow user to bring their own test templating when using KafkaClusterExtension #249

merged 2 commits into from
Dec 7, 2023

Conversation

k-wall
Copy link
Contributor

@k-wall k-wall commented Dec 6, 2023 •
edited
Loading

Type of change

Select the type of your PR

  • Bugfix

Description

As described by #248, a defect currently prevents the user taking advantage of Junit test templating at the same time as making use of the KafkaClusterExtension. This fix resolves the issue by being more discerning when deciding if the user is making use of KCE's DimensionMethodSource/ConstraintsMethodSource.

Additional Context

Why are you making this pull request?

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

@k-wall k-wall requested review from SamBarker and robobario December 6, 2023 14:45
@k-wall k-wall added the bug Something isn't working label Dec 6, 2023
@k-wall k-wall linked an issue Dec 6, 2023 that may be closed by this pull request
Junit test templating fails if another TestTemplateInvocationContextProvider used #248
Closed
@k-wall k-wall force-pushed the issue-248 branch 2 times, most recently from b2123ec to 9db0031 Compare December 6, 2023 14:48
@k-wall
Fix kroxylicious#248: Allow user to bring their own test templating w…
d5cd834 
…hen using KafkaClusterExtension

Signed-off-by: kwall <kwall@apache.org>
@k-wall k-wall mentioned this pull request Dec 6, 2023
Merged
7 tasks
SamBarker
SamBarker approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

That must have been fun to find...

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@k-wall k-wall merged commit cccfacd into kroxylicious:main Dec 7, 2023
3 checks passed
@k-wall k-wall deleted the issue-248 branch December 7, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamBarker SamBarker SamBarker approved these changes

@robobario robobario Awaiting requested review from robobario

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Junit test templating fails if another TestTemplateInvocationContextProvider used
2 participants
@k-wall @SamBarker