Merge pull request #142 from kristianmandrup:fix-trim

Fixes trim - test passes
kristianmandrup · Mar 30, 2023 · f3f17ef · f3f17ef
2 parents 5fd68ae + 0f820ff
commit f3f17ef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/types/string/string.js b/src/types/string/string.js
@@ -27,6 +27,7 @@ export class YupString extends YupMixed {
   get typeEnabled() {
     return [
       "normalize",
+      "trim",
       "minLength",
       "maxLength",
       "pattern",

diff --git a/test/types/string/trim.test.js b/test/types/string/trim.test.js
@@ -3,8 +3,7 @@ import { createStr, createSchema } from "./_helpers";
 describe("trim - strict", () => {
   const conf = { trim: true, strict: true, key: "name" };
   describe("create schema", () => {
-    // TODO
-    test.skip("trim", () => {
+    test("trim", () => {
       expect(createStr(conf)).toBeTruthy();
     });
   });
@@ -20,8 +19,8 @@ describe("trim - strict", () => {
       expect(valid).toBeTruthy();
     });
 
-    // todo: why does this fail!?
-    test.skip("invalid name - not trimmed", () => {
+
+    test("invalid name - not trimmed", () => {
       const valid = schema.isValidSync({
         name: "   zxy124 "
       });