Tweak "Parallel Same-Sound Limit" Option

[andrikpowell]

So there are a couple things I'd like to pitch here... But first, I need to explain what my main issue with this option is in its current form.

I will admit I didn't understand what this option was supposed to do at first, and I don't think that the option's current wording helped. But I need to explain how this option works, to show why I think it should be tweaked.

So there are two options:

• Parallel Same-Sound Limit
• Parallel Same-Sound Window

First off, we need to understand what "Parallel Same-Sound Limit" does. Essentially, what this option tries to limit the amount of sounds that are played. However it only limits the sounds with two criteria: 1) if it is the same sound, and 2) if it is playing at the same time.

The best example of this would be a group of Revenants, as they are very loud and are very noisy. This option can be used to limit how many Revenant "wake" sounds happen under a certain "window". This is where the second option comes in called "Parallel Same-Sound Window". Essentially this value is within how many tics does it limit the same-sounds.

Now that we have an understanding of the option, I'm going to explain my issue with the setting. The value of "Parallel Same-Sound Limit" can be set from 0-32. 32 translates to 32 iterations of the same-sound can be played at once, whereas 1 translates to only 1 of the same-sound can be played at once. Following this logic, the higher the value, the more sounds can play...

However, what happens when you set the "Parallel Same-Sound Limit" to 0? Well apparently the limit is removed altogether. The problem here is that the logic is supposed to be the lower the value, the more sounds are being limited. The higher the value, the less sounds limited. However 0 breaks the logic, as the limit is removed, acting far closer to the value of 32 for the limit.

My suggestion is to separate the on/off functionality of 0 currently present the "Parallel Same-Sound Limit" option, into a new boolean option acting as an on/off switch. With the current option becoming a "Parallel Same-Sound Number" option to specify how many sounds to limit instead.

I will mention that I have these options renamed in Nyan Doom as the following:

• Overlapping Same-Sound Limit
• Number of Overlapping Sounds
• Sound Replay Window (tics)

Although I haven't renamed these options in this PR, as I'm not sure if people would like them renamed. These names just make slightly more sense to me.

[jackrjli]

An alternative I just thought of is to display 0 as "disabled" instead of the number. Not sure how much reworking of the menu code that would take, but there are some other settings (FPS limit, rewind timeout) that could benefit from the same.