-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark Overlay Fixes #584
base: master
Are you sure you want to change the base?
Dark Overlay Fixes #584
Conversation
Let me know if you have a better idea for the Hexen fix (Software is what has the issue). There are two ways to approach this:
Edit: I actually think the second option is better, since it's same way that |
8a4dccd
to
7f6134e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont know how common it is in the code, but I dont like seeing W_GetNumForName being called every frame.
Could you use the variable LevelUseFullBright
? It is set to false if FOGMAP is being used. No need for that new function
7f6134e
to
94485bd
Compare
94485bd
to
a09a230
Compare
Ok, here's a completely different approach. I went with your Curious what you think :) |
Sorry Re-did this PR with a different branch name.
I'm kinda treating this PR as my Dark Overlay omnibus PR.