-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please ship TypeScript definitions #303
Comments
Looks like there's a process to deprecate the DefinitelyTyped types that we should follow when we do this - see DefinitelyTyped/DefinitelyTyped#20258 for an example. |
Any updates? |
@ExplodingCabbage @tmm1 Would you accept a PR to include the types from here directly into this repo? |
@isaachinman sure, that'd save me some work figuring out how to do that and be a great start point. |
Spent about 15 minutes updating the rollup config to emit types based on your JavaScript codebase. Unfortunately, those declarations are completely incorrect. You'd need to either rewrite the entire repo in TS, or at least annotate via jsdoc for proper types. Until then, I think the straightforward thing to do is basically inline the I've opened a PR and tested it against my own consuming application. |
Some definitions are available here.
Thanks
The text was updated successfully, but these errors were encountered: