Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Rust support #153

Open
popzxc opened this issue Dec 14, 2019 · 3 comments
Open

[RFC] Rust support #153

popzxc opened this issue Dec 14, 2019 · 3 comments

Comments

@popzxc
Copy link
Collaborator

popzxc commented Dec 14, 2019

I'm not sure whether it's applicable for this project, but I would love it if this bot will be not haskell-targeted and there will be support of other programming languages linting.

In particular, I'm interested in rust:

  • rustfmt checks for appropriate formatting;
  • rust-clippy checks for code quality.

Adding of this feature support doesn't seem to be hard in general (those tools can output JSON), but this will cause the following drawbacks:

  • rust toolchain (which includes rustup, rustc, rust-std, cargo, rustfmt and clippy) will be required to be installed for testing. This can be done in two commands (rustup bootstraps everything on its own), but I'm not sure whether it's rationale to make project maintainers depend on the additional language.
  • there seems to be no deployment script in the repo, so I assume that deployment is made by hands, and this feature will require the responsible person to install rust on the deployment server, which I can't help with (except for consulting, of course).

So @chshersh / @vrom911 can you please tell whether you like this feature or not? If you do, I'll be happy to implement it.

This feature depends on #110.

@vrom911
Copy link
Member

vrom911 commented Dec 18, 2019

Wow, this is a cool idea 🚀

Initially, we wanted to make it be general-purpose, so such proposals completely suit the purposes of the hintman.

I think we would need to think about the config first as you mentioned and to decide with the format so that it would be possible to setup up it for other languages and extend if necessary.

Sorry, if it would take some time to decide on that, as we are a bit short on time at the moment, but it should go faster after the holidays 🙂
Also, as none of us knows Rust, it could probably take more time to get into Rust tools and how to use it. Currently, we are using HLint as a library, which makes things easier a bit.

@chshersh
Copy link
Contributor

@vrom911 Thanks for writing this! These are my thoughts as well. I only want to add that we deploy Hintman to heroku using thestack buildpack:

@popzxc
Copy link
Collaborator Author

popzxc commented Dec 18, 2019

Also, as none of us knows Rust, it could probably take more time to get into Rust tools and how to use it.

I'm always open for guiding/assistance, if needed. Also, once configuration issue will be solved, I can provide (at least initial/draft) implementation, of course.

Sorry, if it would take some time to decide on that, as we are a bit short on time at the moment, but it should go faster after the holidays

Sure! We aren't bothered with deadlines, are we? 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants