Commented waves oscillator files and improved make #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dsp::BiQuad &postlpf = s_waves.postlpf; | ||
| // pre filter for bit crushing | ||
| dsp::BiQuad &prelpf = s_waves.prelpf; | ||
| // pre filter for bit crushing |
There was a problem hiding this comment.
Suggested change
| // pre filter for bit crushing | |
| // post filter for bit crushing |
| } | ||
|
|
||
| // this method checks the which waves the user has changed and selects the corresponding |
There was a problem hiding this comment.
Suggested change
| // this method checks the which waves the user has changed and selects the corresponding | |
| // this method checks which waves the user has changed and selects the corresponding |
|
Could these be put in doxygen? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have commented waves.cpp and waves.hpp, so that beginners get a better start into SDK development. For that purpose, I am also creating a video tutorial: https://www.youtube.com/watch?v=ouGBnYXUT40
This PR serves mainly for reference purposes.