Add new webhooks and rename legacy webhooks #254
Conversation
lenkaklimcikova
force-pushed
the
DEL-4734-webhoks-vnext
branch
2 times, most recently
from
797f56a to
4e248a4
Compare
There was a problem hiding this comment.
There was a problem hiding this comment.
good point thanks, didn't think about changing the old ones,too :D fixed
| @@ -1,7 +1,7 @@ | |||
| using Newtonsoft.Json; | |||
| using System.Collections.Generic; | |||
|
|
|||
| namespace Kontent.Ai.Management.Models.Webhooks.Triggers; | |||
| namespace Kontent.Ai.Management.Models.LegacyWebhooks.Triggers; | |||
|
|
|||
| /// <summary> | |||
There was a problem hiding this comment.
| @@ -1,7 +1,7 @@ | |||
| using Newtonsoft.Json; | |||
| using System.Collections.Generic; | |||
|
|
|||
| namespace Kontent.Ai.Management.Models.Webhooks.Triggers; | |||
| namespace Kontent.Ai.Management.Models.LegacyWebhooks.Triggers; | |||
There was a problem hiding this comment.
| @@ -2,7 +2,7 @@ | |||
| using Newtonsoft.Json; | |||
| using System.Collections.Generic; | |||
|
|
|||
| namespace Kontent.Ai.Management.Models.Webhooks.Triggers; | |||
| namespace Kontent.Ai.Management.Models.LegacyWebhooks.Triggers; | |||
There was a problem hiding this comment.
|
|
||
| /// <summary> | ||
| /// Determines if the webhook is enabled. By default, the enabled property is set to true. | ||
| /// More info: https://kontent.ai/learn/reference/management-api-v2#section/Webhook-object |
There was a problem hiding this comment.
Kontent.Ai.Management/Models/Webhooks/Triggers/Language/LanguageActionModel.cs
Outdated
Show resolved
Hide resolved
| namespace Kontent.Ai.Management.Models.Webhooks.Triggers.Taxonomy; | ||
|
|
||
| /// <summary> | ||
| /// Represents taxonomy actions. |
There was a problem hiding this comment.
singular - > Represents * action.
| /// <summary> | ||
| /// Represents the delivery slot model. | ||
| /// </summary> | ||
| public enum DeliverySlotModel |
| namespace Kontent.Ai.Management.Models.Webhooks.Triggers; | ||
|
|
||
| /// <summary> | ||
| /// Represents the delivery slot model. |
There was a problem hiding this comment.
/// Represents the delivery slot.
| namespace Kontent.Ai.Management.Models.LegacyWebhooks; | ||
|
|
||
| /// <summary> | ||
| /// Represents the webhook create model. |
There was a problem hiding this comment.
/// Represents the legacy webhook create model.
lenkaklimcikova
force-pushed
the
DEL-4734-webhoks-vnext
branch
from
4e248a4 to
f953aa8
Compare
|
You have renamed the action enums to names with suffix Enum, please keep it consistent in the namespace Kontent.Ai.Management.Models.Webhooks. There are enums without this suffix. I'd prefer removing those suffixes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
==========================================
- Coverage 89.31% 84.93% -4.38%
==========================================
Files 246 263 +17
Lines 2816 2907 +91
Branches 315 320 +5
==========================================
- Hits 2515 2469 -46
- Misses 298 343 +45
- Partials 3 95 +92 ☔ View full report in Codecov by Sentry. |
pokornyd
force-pushed
the
DEL-4734-webhoks-vnext
branch
from
1d5d606 to
26c9d4b
Compare
Motivation
Enable customers to use both webhook versions - new and legacy.
DEL-4734