Enable specifying custom Recombee region (also updates a lot of packages and rewrites to Vite) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for recombee-rewrite ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IvanKiral
requested changes
Apr 5, 2024
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm ci | ||
| - uses: dprint/check@v2.2 | ||
| - run: npm run lint |
There was a problem hiding this comment.
The step above dprint/check@v2.2 checks formatting.
| @@ -160,7 +160,7 @@ $ npm install | |||
| $ netlify dev | |||
| ``` | |||
|
|
|||
| The custom element is created with [Create React App](https://create-react-app.dev/). | |||
| The custom element is created with [Vite](https://vitejs.dev/). | |||
There was a problem hiding this comment.
let's chage the screenshot for new webhooks 💪
package-lock.json
Outdated
| "dprint": "^0.36.1", | ||
| "eslint": "^8.41.0", | ||
| "@kontent-ai/delivery-sdk": "^14.8.0", | ||
| "@kontent-ai/webhook-helper": "^2.1.0", |
There was a problem hiding this comment.
new webhooks should be realeased soon. let's see if dependabot will announce it
There was a problem hiding this comment.
Dependabot only announces fixes for security issues. I don't believe that this update will be marked as such. 😄
But I updated the package anyway.
| : null; | ||
| }) | ||
| .filter(notNull), | ||
| ]; | ||
| return this.client.send(new Recombee.requests.Batch(requests)); | ||
| return this.client.send(new Recombee.requests.Batch(requests)).then(() => {}); |
There was a problem hiding this comment.
nit: those looks kind of fun :D still no at level of my logging in data-ops
- update recombee client
JiriLojda
force-pushed
the
DEVREL-1136_update_packages
branch
from
da6ec5b to
f41f578
Compare
IvanKiral
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #
issue numberIf no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?