Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Fix testcontainer tests to make them work on GitLab runners #236

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

dfinteligenz
Copy link
Contributor

Description

  • Fix testcontainers indirect dependencies to make testcontainer tests work on GitLab
  • Fix testcontainer waiting rules to wait for a specific log AND the exposed port
  • Added a 3 minute deadline to all testcontainer tests for avoiding context deadline exceeded exceptions

Motivation and Context

We had to make some changes on the testcontainer tests to make them work on GitLab runners.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other changes (ci configuration, documentation or any other kind of changes)

Checklist:

  • I have created tests for my code changes, and the tests are passing.
  • I have executed the pre-commit hooks locally.
  • My change requires a change to the documentation (create a new issue if the documentation has not been updated).
  • I have updated the documentation accordingly.

@dfinteligenz dfinteligenz self-assigned this Jan 15, 2024
@dfinteligenz dfinteligenz changed the title Fix testcontainer tests to wait for exposed ports Fix testcontainer tests to work on GitLab runners Jan 15, 2024
kafkaphoenix
kafkaphoenix previously approved these changes Jan 15, 2024
@dfinteligenz dfinteligenz changed the title Fix testcontainer tests to work on GitLab runners Fix testcontainer tests to make them work on GitLab runners Jan 15, 2024
alexrodfe
alexrodfe previously approved these changes Jan 15, 2024
@dfinteligenz dfinteligenz dismissed stale reviews from alexrodfe and kafkaphoenix via d626b31 January 15, 2024 12:30
Copy link

Quality Gate Passed Quality Gate passed for 'KAI - Admin API'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'KAI - NATS Manager'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dfinteligenz dfinteligenz enabled auto-merge (squash) January 15, 2024 16:29
Copy link

This PR is stale because it has been open 15 days with no activity. Please check it out and remove the old-pr label when finished.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants