Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

split internal from rest-api workspace #93

Merged
merged 8 commits into from
May 8, 2024

Conversation

filariow
Copy link
Member

  • add viewmodel
  • rename operator's Workspace to InternalWorkspace
  • completing CRD refactor
  • fix proxy config
  • fix urls in server

Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow filariow requested a review from sadlerap April 24, 2024 19:51
Copy link
Member

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good (since it's largely a rename), but I haven't tested in a cluster yet.

@filariow filariow requested a review from sadlerap May 7, 2024 08:19
Copy link
Member

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@filariow filariow merged commit c80cd12 into konflux-workspaces:main May 8, 2024
10 checks passed
@filariow filariow deleted the crd-int-vm branch May 8, 2024 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants