From 80f097fc2ca1415dfb63a0eaf8182a61f37c6ab6 Mon Sep 17 00:00:00 2001 From: Andy Sadler Date: Thu, 23 May 2024 03:22:30 -0500 Subject: [PATCH] ci: run more tests more often (#155) If we want to make the unit-testing job always pass before we can merge a PR, we need to have it run in almost all circumstances. With this change, all PRs will have unit tests run, not just when relevant paths have changed. This also sets up unit testing for operator/ and fixes a bug where we were running the latest version of golang-ci instead of the pinned version. Signed-off-by: Andy Sadler Co-authored-by: Francesco Ilario --- .github/workflows/ci.yaml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index fe5eb099..49fe018f 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -1,11 +1,7 @@ name: Server CI on: # yamllint disable-line rule:truthy - pull_request: - paths: - - "server/**" - - "hack/tools/**" - - ".github/**" + pull_request: {} push: branches: [main] @@ -17,6 +13,11 @@ jobs: unit: name: Unit tests runs-on: ubuntu-22.04 + strategy: + matrix: + include: + - directory: server + - directory: operator steps: - name: Set up Go @@ -29,7 +30,7 @@ jobs: - name: Run tests # todo: set up code coverage? - run: make -C server test + run: make -C "${{ matrix.directory }}" test lint-go: name: Lint code @@ -47,7 +48,7 @@ jobs: - name: Determine golang-ci version id: golangci_version run: | - echo "version=$(go mod edit -json | jq '.Require | map(select(.Path == "github.com/golangci/golangci-lint"))[].Version')" >> $GITHUB_OUTPUT + echo "version=$(go mod edit -json hack/tools/golang-ci/go.mod | jq '.Require | map(select(.Path == "github.com/golangci/golangci-lint"))[].Version')" >> $GITHUB_OUTPUT - name: Lint with golang-ci uses: golangci/golangci-lint-action@v6