Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

Commit

Permalink
ci: run more tests more often
Browse files Browse the repository at this point in the history
If we want to make the unit-testing job always pass before we can merge
a PR, we need to have it run in almost all circumstances. With this
change, all PRs will have unit tests run, not just when relevant paths
have changed.

This also sets up unit testing for operator/ and fixes a bug where we
were running the latest version of golang-ci instead of the pinned
version.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
  • Loading branch information
sadlerap committed May 22, 2024
1 parent d46dc6f commit 7b587a1
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
name: Server CI

on: # yamllint disable-line rule:truthy
pull_request:
paths:
- "server/**"
- "hack/tools/**"
- ".github/**"
pull_request: {}
push:
branches: [main]

Expand All @@ -17,6 +13,11 @@ jobs:
unit:
name: Unit tests
runs-on: ubuntu-22.04
strategy:
matrix:
include:
- directory: server
- directory: operator

steps:
- name: Set up Go
Expand All @@ -29,7 +30,7 @@ jobs:

- name: Run tests
# todo: set up code coverage?
run: make -C server test
run: make -C "${{ matrix.directory }}" test

lint-go:
name: Lint code
Expand All @@ -47,7 +48,7 @@ jobs:
- name: Determine golang-ci version
id: golangci_version
run: |
echo "version=$(go mod edit -json | jq '.Require | map(select(.Path == "github.com/golangci/golangci-lint"))[].Version')" >> $GITHUB_OUTPUT
echo "version=$(go mod edit -json hack/tools/golang-ci/go.mod | jq '.Require | map(select(.Path == "github.com/golangci/golangci-lint"))[].Version')" >> $GITHUB_OUTPUT
- name: Lint with golang-ci
uses: golangci/golangci-lint-action@v6
Expand Down

0 comments on commit 7b587a1

Please sign in to comment.