Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of ignore notation in storybook eslint and transition to actions function #489

Merged

Conversation

kamegoro
Copy link
Contributor

@kamegoro kamegoro commented Nov 4, 2023

Changes Proposed

Closes: #488

Refactoring related to Storybook was done.
Details are left in the issue

Check List

  • The title of my pull request is a short description of the changes
  • This PR relates to some issue:
  • I have documented the changes made (if applicable)
  • I have covered the changes with unit tests

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de1915e) 29.85% compared to head (3ae42f5) 29.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #489   +/-   ##
=======================================
  Coverage   29.85%   29.85%           
=======================================
  Files          10       10           
  Lines        1323     1323           
=======================================
  Hits          395      395           
  Misses        887      887           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kamegoro kamegoro marked this pull request as draft November 4, 2023 04:16
@kamegoro kamegoro marked this pull request as ready for review November 4, 2023 04:16
@undera undera merged commit 4c84b79 into komodorio:main Nov 4, 2023
4 checks passed
@undera
Copy link
Collaborator

undera commented Nov 4, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of ignore notation in storybook eslint and transition to actions function
3 participants