fix: history-max does not work when exec helm upgrade (#507)

Signed-off-by: iiiceoo <iiiceoo@foxmail.com>
komodorio · Feb 2, 2024 · f7e92f1 · f7e92f1
1 parent 6a7cade
commit f7e92f1
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/pkg/dashboard/objects/releases.go b/pkg/dashboard/objects/releases.go
@@ -330,6 +330,7 @@ func (r *Release) Upgrade(repoChart string, version string, justTemplate bool, v
 	}
 
 	cmd := action.NewUpgrade(hc)
+	cmd.MaxHistory = r.Settings.MaxHistory
 
 	cmd.Namespace = r.Settings.Namespace()
 	cmd.Version = version

diff --git a/pkg/dashboard/server.go b/pkg/dashboard/server.go
@@ -199,7 +199,6 @@ func NewHelmConfig(origSettings *cli.EnvSettings, ns string) (*action.Configurat
 		helmDriver, log.Debugf); err != nil {
 		return nil, errorx.Decorate(err, "failed to init Helm action config")
 	}
-	actionConfig.Releases.MaxHistory = origSettings.MaxHistory
 
 	return actionConfig, nil
 }