Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure OpenAI Support #410

Closed
wants to merge 2 commits into from
Closed

Conversation

gmuffiness
Copy link

Update the OpenAI package to support Azure OpenAI models with minimal code changes.
I referred to the code here (openai node)

I checked that OpenAI model functionality remains unaffected.

related issue : #389

(p.s. I plan to contribute various features, so instead of the main branch, I made a separate feature branch and reopen the PR.)

@Zgrill2
Copy link

Zgrill2 commented Feb 9, 2025

What was your reasoning for the design choice to not use the AzureOpenAI class provided by the openai library?

@gmuffiness
Copy link
Author

I saw from the link that it seemed possible to achieve the same functionality using the OpenAI library, so I aimed for minimal changes in my implementation.

However, it does seem like this approach is becoming somewhat deprecated, so using the AzureOpenAI class looks like the better option. I noticed your recent PR, and that approach also looks good, so I’ll go ahead and close this PR.

@gmuffiness gmuffiness closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants