Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NINO validation for GB #121

Merged
merged 4 commits into from
Nov 16, 2024
Merged

Fix NINO validation for GB #121

merged 4 commits into from
Nov 16, 2024

Conversation

strotgen
Copy link
Contributor

The prefixes in the code are based on documentation archived in 2012. This PR updates the validation rules to use the most recent and accurate ones.

New validations: https://www.gov.uk/hmrc-internal-manuals/national-insurance-manual/nim39110

All prefixes are valid except:

  • The characters D, F, I, Q, U, and V are not used as either the first or second letter of a NINO prefix.
  • The letter O is not used as the second letter of a prefix.
  • Prefixes BG, GB, KN, NK, NT, TN and ZZ are not to be used

Copy link
Owner

@koblas koblas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, sorry for the delay in getting back to you

@koblas koblas merged commit 6a84d84 into koblas:main Nov 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants