Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is-gen-fn dependency #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yelworc
Copy link

@yelworc yelworc commented May 5, 2021

The is-gen-fn package causes a DeprecationWarning with Node 16:

 Uncaught DeprecationWarning: Invalid 'main' field in '/home/crowley/work/uniq/uniq-conferencier/node_modules/is-gen-fn/package.json' of 'yes'. Please either fix that or report it to the module author
  at tryPackage (node:internal/modules/cjs/loader:359:15)
  […]

Since it is fairly trivial, just include the generator function check here.

The is-gen-fn package causes a DeprecationWarning with Node 16; since
it is fairly trivial, just include the generator function check here.
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have replaced the is-gen-fn with is-generator-function here #128 and it available in the next release when the merge happened.

@yelworc
Copy link
Author

yelworc commented May 5, 2021

Ah, I did glance at the open issues, but didn't look closely at the open PRs! Alright, feel free to close this, then (unless you maybe want to merge it as a temporary fix, since it could be released as a patch version until #128 lands).

@Aldekein
Copy link

The DeprecationWarning: Invalid 'main' field bugs me too. Its source is is-gen-fn@0.0.1 in dependencies of joi-router.

@flofehrenbacher-sz
Copy link

Any updates regarding this PR? Would also love to use it without the deprecation warning

@3imed-jaberi
Copy link
Member

3imed-jaberi commented Dec 3, 2022

Updates: For now, you can use @koa-better-modules/joi-router which contains all the changes that must be in v9.x.x until I can publish the next official release under @koa/joi-router (expected in the coming few weeks).

Check 👀

@hckhanh
Copy link

hckhanh commented Dec 31, 2022

Hi @3imed-jaberi, is there anything new for this PR, I created another PR for this: #137

@jackykwan-eventx
Copy link

@3imed-jaberi hello, is this package currently still under maintenence ?
seems like no updates for a long period of time

@3imed-jaberi
Copy link
Member

Hey Guys, next week we will publish the latest version (including the latest fixed) under @koa/joi-router.
If you don't like to wait for next week, you can use the latest version by installing @koa-better-modules/joi-router

More details here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants