Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v9.x.x πŸš€ #128

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

3imed-jaberi
Copy link
Member

@3imed-jaberi 3imed-jaberi commented Apr 28, 2021

Hi @aheckmann πŸ‘‹

Changes:

  • remove .npmignore file ❌
  • lint code through eslint πŸ’…πŸ»
  • update LICENSE πŸ—
  • update test code πŸ§ͺ
  • improve coverage πŸ’―
  • update all deps πŸ₯‘
  • remove some deps (last update on 25/03/2022) and used custom helpers and utils πŸ“¦
  • use ecmascript 6+ features ✨
  • update README.md πŸ“‹

Issues:

You can close these issues #131 #130 #126 #116 #115 #74 and #73.
For #62, I think the last comment represents a solution. πŸ€” !!
For #56, Tell me here how can I help here.


READY TO NEXT RELEASE πŸš€

@3imed-jaberi
Copy link
Member Author

3imed-jaberi commented Jul 13, 2021

Hi @aheckmann, as you can see in #130 the is-gen-fn module make some issues ... so kindly can you take a look here.
(also, can you add me as maintainer to help you by maintain the module and publish it to npm).

@jiminikiz
Copy link

It's been a while since this PR has been up -- it looks like @3imed-jaberi put up some good code here.

Anything I can do to help the maintainers get this in?

@arashkay
Copy link

arashkay commented Oct 6, 2021

Same issue with node16

@3imed-jaberi
Copy link
Member Author

3imed-jaberi commented Oct 6, 2021

I think this Bump is required by the community (which use Node.js 15+) as you can see here. So, please, anyone have write access and npm access... πŸš€

ping @aheckmann @niftylettuce @jonathanong @miwnwski

@jonathanong
Copy link
Member

@3imed-jaberi I can give you access to the repo but I don't have npm access lol

cc @aheckmann @niftylettuce @miwnwski

@miwnwski
Copy link
Member

miwnwski commented Oct 8, 2021

Same. I have no npm access :/

@yelworc
Copy link

yelworc commented Mar 17, 2022

Soo… Since this package is evidently stuck in the mud… how do you feel about publishing your fork as koa-joi-router2, @3imed-jaberi? πŸ™‚

@3imed-jaberi
Copy link
Member Author

3imed-jaberi commented Mar 25, 2022

Soo… Since this package is evidently stuck in the mud… how do you feel about publishing your fork as koa-joi-router2, @3imed-jaberi? πŸ™‚

@jonathanong, can you add me as a maintainer for this project, and then I will make the new release and give the ability to the community to use this package from GitHub directly until @aheckmann give me npm access or publish a new version with this name @koa/joi-router.

Copy link
Member Author

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Announcement about the joi-router@v9.x;

Finally, joi-router@v9.x is here. I have published this PR under @koa-better-modules/joi-router πŸŽ‰!

If @aheckmann is back someday, we can back here and merge it! about bugs or feature fell free to ping me here in this repo. or on the new one here.

Also, I would like to make an acknowledgment for people who help and/or follow this PR;

Thanks ❀️!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants