Typescript) fix errors #202
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -33,4 +33,3 @@ jobs: | ||
|
|
||
| - name: Run tsc | ||
| run: npx tsc | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -26,4 +26,5 @@ coverage/ | ||
| *-debug.log | ||
| *-error.log | ||
|
|
||
| .vscode/extensions.json | ||
| .vscode/settings.json | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| // Use IntelliSense to learn about possible attributes. | ||
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "type": "chrome", | ||
| "request": "attach", | ||
| "name": "Attach to Karma-Chrome", | ||
| "sourceMaps": true, | ||
| // "restart": true, | ||
| // "timeout":180000, | ||
| "port": 9222, | ||
| "webRoot": "${workspaceFolder}" | ||
| } | ||
| ] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -32,6 +32,12 @@ ci: | ||
| lint: | ||
| $(NPX) standard | ||
|
|
||
| tsc: | ||
| $(NPX) tsc | ||
|
|
||
| dts: | ||
| $(NPX) tsc --noEmit false | ||
|
|
||
| docker-build: | ||
| $(DOCKER) build . --tag tko | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /// <reference types="jasmine" /> | ||
| /// <reference types="jquery" /> | ||
|
|
||
| //export {} allows redefining window module | ||
| export { }; | ||
brianmhunt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| declare global { | ||
|
There was a problem hiding this comment. We generally want to be mindful of polluting the global namespace, so we will need to be careful to not distribute this, and not rely on types defined only here. There was a problem hiding this comment. I agree to 100%. The best global.d.ts is an empty one. Some oldstyle global objects like jquery or required need to be currently declared. The Jasmine and Mocha problem is homemade, but removing Jasmine is a bigger task. For compatibility, some global knockout types remain here because refactoring leads to invasive changes. Changing the prototype chains of the TKO base classes to js/ts classes can be done in later steps, but it breaks some of the critical interfaces of knockoutjs. We had try that. I will reorganise some global declarations. There was a problem hiding this comment. Update: "Import type" was a game changer. I also found a solution to create an object using a function in TypeScript like JavaScript for 'subscribable'. Changing the prototype chain of the objects (classes) in @tko/observable is a different challenge. |
||
|
|
||
| // Below just informs IDE and/or TS-compiler (it's set in `.js` file). | ||
| interface Window { | ||
| DEBUG: boolean | ||
| amdRequire: any | ||
| require: any | ||
| jQuery: JQueryStatic | ||
| innerShiv // TODO: For IE<9.. we could also remove it | ||
| } | ||
|
|
||
| //Jasmine and Mocha define duplicated functions, is a problem for the type system | ||
|
There was a problem hiding this comment. That's how it works for now. Jasmine 1.3 is old and there aren't many tests in Mocha. Perhaps a facade that redirects Jasmine 1.3 to Mocha/Chai is a future solution. There was a problem hiding this comment. yes, those or playwright.dev or bun.sh. They're pretty tightly tied to Jasmine right now, so it'd be an effort, but homogenizing the runner would help a lot. There was a problem hiding this comment. A current version 5.6 of Jasmine is probably the simplest solution. Although a lot has changed here too. Jest is also similar. In my opinion, Playwright is more like browser automation for e2e testing. It is a very good replacement for Selenium. |
||
| //This namespace merges the jasmine namespace to correct same tsc warnings | ||
| namespace jasmine { | ||
|
|
||
| function setNodeText(node, text: string): void | ||
| var Spec: any; | ||
| function getGlobal(): any; | ||
| var updateInterval: number | ||
| function resolve(promise: Promise<boolean>) | ||
| function prepareTestNode() : HTMLElement | ||
| function nodeText(node) | ||
| var Clock: Clock | ||
| function getEnv(): any; | ||
|
|
||
| var FakeTimer: any | ||
| var undefined: undefined | ||
| var browserSupportsProtoAssignment: any | ||
| var ieVersion: any | ||
|
|
||
| var Matchers: Matchers | ||
|
|
||
| interface Matchers<T> { | ||
| toContainText(expected: string, ignoreSpaces: boolean): boolean | ||
| toHaveOwnProperties(expectedProperties: any): boolean | ||
| toHaveTexts(expectedTexts: any): boolean | ||
| toHaveValues(expectedValues: any): boolean | ||
| toHaveCheckedStates(expectedValues: any): boolean | ||
| toThrowContaining(expected: any): boolean | ||
| toEqualOneOf(expectedPossibilities: any): boolean | ||
| toContainHtml(expectedHtml: any, postProcessCleanedHtml: any): boolean | ||
| toHaveSelectedValues(expectedValues: any): boolean | ||
| toContainHtml(expectedValues: any): boolean | ||
| toHaveNodeTypes(expectedTypes: any): boolean | ||
| toContainHtmlElementsAndText(expectedHtml: any): boolean | ||
| } | ||
|
|
||
| interface Clock { | ||
| mockScheduler: any | ||
| } | ||
|
|
||
| interface Spy { | ||
| reset(): any | ||
| } | ||
| } | ||
|
|
||
| //Knockout Types https://github.com/knockout/knockout/blob/master/build/types/knockout.d.ts#L404 | ||
| // Type definitions for Knockout | ||
| // Project: http://knockoutjs.com | ||
| // Definitions by: Maxime LUCE <https://github.com/SomaticIT>, Michael Best <https://github.com/mbest> | ||
|
|
||
| // Treeshaked for TKO: Almost all type definitions are moved to the TKO source. | ||
|
|
||
| interface SymbolConstructor { | ||
| observable?: Symbol; | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's an equivalent with esbuild [1] if we wanted to re-enable this
[1] https://esbuild.github.io/analyze/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's cool, I didn't know that before