error[E0658]: use of unstable library feature 'renamed_spin_loop'

[MoralCode]

When trying to set up a new machine (a VM) to run knix using the ansible scripts, i ran into the following error:

error[E0658]: use of unstable library feature 'renamed_spin_loop'
 --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/parking_lot_core-0.9.7/src/spinwait.rs:9:5
  |
9 | use core::hint::spin_loop;
  |     ^^^^^^^^^^^^^^^^^^^^^
  |
  = note: see issue #55002 <https://github.com/rust-lang/rust/issues/55002> for more information

error[E0658]: use of unstable library feature 'renamed_spin_loop'
  --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/parking_lot_core-0.9.7/src/spinwait.rs:16:9
   |
16 |         spin_loop()
   |         ^^^^^^^^^
   |
   = note: see issue #55002 <https://github.com/rust-lang/rust/issues/55002> for more information

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0658`.
error: could not compile `parking_lot_core`.

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed
make[1]: *** [Makefile:26: target/release/TriggersFrontend] Error 101

Searching online led me to this issue on another project that suggested updating rust to 1.54, presumably a version that has integrated this feature into the stable branch. When i tried changing this in build_env.mk it seemed to cause other problems later on, so maybe this is a more complicated fix

[MoralCode]

looks like rust 1.49 was where spin_loop became stable

1.49 seems to have much fewer errors than there were in the build i did with 1.54:

error[E0277]: the trait bound `serde_urlencoded::ser::Error: From<serde_urlencoded::ser::Error>` is not satisfied
   --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/awc-2.0.0/src/sender.rs:236:42
    |
236 |             Err(e) => return Error::from(e).into(),
    |                                          ^
    |                                          |
    |                                          expected an implementor of trait `From<serde_urlencoded::ser::Error>`
    |                                          help: consider borrowing here: `&e`
    |
    = note: required because of the requirements on the impl of `From<serde_urlencoded::ser::Error>` for `actix_http::Error`
    = note: required by `std::convert::From::from`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.
error: could not compile `awc`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed
make[1]: *** [Makefile:26: target/release/TriggersFrontend] Error 101

[MoralCode]

looks like theres a known issue where a breaking change (without a subsequent semver bump) was made to the library. relevant version in parking_lot changelog

seems like parking_lot is buried in the dependency tree though

[iakkus]

Hello,

Thanks for looking into this issue. The triggers frontend is an
optional component, so if you want to check the remaining parts, feel free to skip installing that one.

[MoralCode]

Thanks for looking into this issue. The triggers frontend is an optional component, so if you want to check the remaining parts, feel free to skip installing that one.

Thanks for the info! I might give that a try, but it would be nice to fix the issue and be able to use the amazing-looking UI that you included screenshots for in the README (thank you for this BTW, not a lot of other maintainers do that and its super helpful).

Since I'm looking at this codebase for a class project, I have some limited time/interest to contribute to the project if that would help! I'd be interested in learning more about the rust components of this odebase in case that would help!

[iakkus]

By all means, go ahead!

The rust component, TriggersFrontend, is really optional and is not required for the GUI to function (maybe a small portion of the GUI will not be available).

[MoralCode]

Oh i assumed Triggers Frontend was the frontend itself. Can you point me to what file i might look at modifying in order to disable it?

[iakkus]

Nope.

Check out deploy/ folder. If using ansible, just don't make any host triggers frontend. If using helm, start from the Makefile.

[MoralCode]

If using ansible, just don't make any host triggers frontend.

as in remove all hosts from the [triggers_frontend] section of the inventory.cfg? Wouldnt that break something since the README says this:

At least one host should be in [management] and [triggers_frontend] group.

[iakkus]

That should be fine.