Skip to content

Gracefully drain connections when stopping the gateway #1856

Gracefully drain connections when stopping the gateway

Gracefully drain connections when stopping the gateway #1856

Triggered via pull request April 27, 2024 13:17
Status Failure
Total duration 50s
Artifacts

knative-style.yaml

on: pull_request
style  /  changes
4s
style / changes
style  /  ...  /  Auto-format and Check
17s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
24s
style / Golang / Lint
style  /  ...  /  Do Not Submit
7s
style / Golang / Do Not Submit
style  /  ...  /  shell
5s
style / suggester / shell
style  /  ...  /  yaml
19s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 6 warnings
style / Golang / Auto-format and Check: test/gracefulshutdown/gracefulshutdown_test.go#L1
Please run goimports. diff --git a/test/gracefulshutdown/gracefulshutdown_test.go b/test/gracefulshutdown/gracefulshutdown_test.go index f33b624..56c9a92 100644 --- a/test/gracefulshutdown/gracefulshutdown_test.go +++ b/test/gracefulshutdown/gracefulshutdown_test.go @@ -68,7 +68,7 @@ func TestGracefulShutdown(t *testing.T) { clients := test.Setup(t) ctx := context.Background() - + // Create a service and an ingress name, port, _ := ingress.CreateTimeoutService(ctx, t, clients) _, client, _ := ingress.CreateIngressReady(ctx, t, clients, v1alpha1.IngressSpec{
style / Golang / Auto-format and Check
Process completed with exit code 1.
style / Golang / Lint: test/gracefulshutdown/gracefulshutdown_test.go#L1
: # knative.dev/net-kourier/test/gracefulshutdown [knative.dev/net-kourier/test/gracefulshutdown.test]
style / Golang / Lint: test/gracefulshutdown/gracefulshutdown_test.go#L127
cannot use metav1.DeleteOptions{…} (value of type "k8s.io/apimachinery/pkg/apis/meta/v1".DeleteOptions) as "k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions value in argument to clients.KubeClient.CoreV1().Pods(gatewayNs).List
style / Golang / Lint: test/gracefulshutdown/gracefulshutdown_test.go#L128
unknown field LabelSelector in struct literal of type "k8s.io/apimachinery/pkg/apis/meta/v1".DeleteOptions (typecheck)
style / Golang / Lint
issues found
style / suggester / shell
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/net-kourier/net-kourier. Supported file pattern: go.sum
style / suggester / yaml
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/net-kourier/net-kourier. Supported file pattern: go.sum
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/net-kourier/net-kourier. Supported file pattern: go.sum
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/net-kourier/net-kourier. Supported file pattern: go.sum