Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.14] Upgrade knative.dev/eventing to latest 1.14 #4113

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Sep 24, 2024

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane labels Sep 24, 2024
@pierDipi
Copy link
Member Author

/test unit-tests

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
Copy link

knative-prow bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/test channel-integration-tests-ssl

@pierDipi
Copy link
Member Author

/test reconciler-tests

@knative-prow knative-prow bot merged commit 1754676 into knative-extensions:release-1.14 Sep 24, 2024
34 checks passed
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request Sep 24, 2024
…xtensions#4113)

* Upgrade knative.dev/eventing to latest 1.14

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Pass PodLister as expected

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Migrate to library SchedulerFunc to use the new signature

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request Sep 25, 2024
…xtensions#4113)

* Upgrade knative.dev/eventing to latest 1.14

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Pass PodLister as expected

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Migrate to library SchedulerFunc to use the new signature

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi added a commit to openshift-knative/eventing-kafka-broker that referenced this pull request Sep 25, 2024
…ol and Upgrade knative.dev/eventing to latest 1.14 (#1279)

* [release-1.14] Allow enabling sarama logging and disabling client pool (knative-extensions#4103) (knative-extensions#4107)

* Allow enabling sarama logging and disabling client pool (knative-extensions#4103)

Add 3 new environment variables:
```
ENABLE_SARAMA_LOGGER       (default: false)
ENABLE_SARAMA_DEBUG_LOGGER (default: false)
ENABLE_SARAMA_CLIENT_POOL  (default: true)
```

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Set GetKafkaClient

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* [release-1.14] Upgrade knative.dev/eventing to latest 1.14  (knative-extensions#4113)

* Upgrade knative.dev/eventing to latest 1.14

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Pass PodLister as expected

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Migrate to library SchedulerFunc to use the new signature

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Fix dispatcherPodLister and run make generate-release

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Clone the matching SO branch

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Add label selector to fix panic error

Error:
```
2024-09-25T10:41:51.023869929Z panic: Unable to fetch k8s.io/client-go/informers/core/v1.PodInformer with selector app.kubernetes.io/kind=kafka-dispatcher from context.
```

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants