-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Class Names in decay and mutators Folders for Backward Compatibility #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments indicating changes that need to be made.
Also, before creating a pull request, try to make sure your branch is up to date with the main branch in my repo.
There are probably better ways to do this, but you can just follow these steps before you submit a pull request to sync my repo with yours:
git fetch upstream
(orgit fetch --all
for simplicity)git checkout main
git merge --ff-only upstream/main
git checkout <your PR branch>
git merge main
(orgit rebase main
if you want)git push
@@ -6,4 +6,4 @@ | |||
from .arithmetic_decay import ArithmeticDecay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All imported classes should be renamed to the reverted names such as ArithDecay
, ExpDecay
, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to rename the imported GeometricDecay
in src/mlrose_ky/algorithms/sa.py
I think the CI tests failed because the class names like |
Coverage reportClick to see where and how coverage changed
The report is truncated to 25 files out of 52. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
Fixed the problems with miss-named class instances and all tests are passing now. Thanks for the help on this! |
This pull request addresses the renaming of classes in the decay and mutators folders to their original names, ensuring backward compatibility with existing codebases that rely on these class names.