Addressing redundent feval with SA and RHC #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knakamura13
requested changes
Jan 22, 2025
| @@ -230,19 +230,21 @@ def evaluate_population_fitness(self) -> None: | |||
| """Evaluate the fitness of the current population.""" | |||
| self.pop_fitness = np.array([self.eval_fitness(indiv) for indiv in self.population]) | |||
|
|
|||
| def set_state(self, new_state: np.ndarray) -> None: | |||
| def set_state(self, new_state: np.ndarray, fitness: float) -> None: | |||
There was a problem hiding this comment.
This new parameter was added without updating the test cases that cover .set_state().
|
Closing PR permanently. I implemented the same improvements on a separate branch, except with fixes for the bugs, and found that there is statistically zero performance difference between the new and old code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever set_state() is called there is an additional function evaluation called but the fitness value would have already been known in the main optimization loop when check if the new state should be accept