Added unit tests for subscriptions

[emarty-maze]

Added sms and email opt-in e2e tests for sitegen
Moved global variables to module
Refactored order confirmation unit test
Setup mock for KlaviyoSubscribeProfilesService
Refactor Site and LocalServiceRegistry Mocks
Completed subscriber tests

Manual Testing Steps

1. Using node 18.16.x, cd into test dir
2. Run npm install
3. Run npm run test:unit

Pre-Submission Checklist:

• You've updated the CHANGELOG following the steps here

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

I followed cases from the following google doc: https://docs.google.com/document/d/1e4p75l_w0P6QfTqWja6sW8rfHGtNbvE5NWXxYszYne4/edit

[cykolln]

@emarty-maze If I'm reading these correctly, these tests evaluate the klaviyo API response when requests are made but don't evaluate the actual behavior of the cartridge code. The code has different behavior in terms of what requests it makes and how many requests are made depending on the phone_number and email that are submitted. I'd like to see these conditionals in the subscribeUser function covered. For example the case for email consent if we receive a 400 with the response indicating an invalid phone number that we should retry the consent request without the phone number. There should be a test verifying that this request is made twice given the 400 API response.

Responses from the API can be mocked but we should be testing that requests are made as expected with the correct arguments and that logging occurs as expected where relevant. Let me know if I need to clarify this, happy to jump on a quick call to discuss!

[emarty-maze]

Hi Claire, thaks for the clarification, and sorry for missing those testing requirements. A call would be great. Let me know a good time for Tuesday (7/25).

…

On Thu, Jul 20, 2023, 6:28 PM Claire Kolln (Integrations Ecom) < ***@***.***> wrote: ***@***.**** requested changes on this pull request. @emarty-maze <https://github.com/emarty-maze> If I'm reading these correctly, these tests evaluate the klaviyo API response when requests are made but don't evaluate the actual behavior of the cartridge code. The code has different behavior in terms of what requests it makes and how many requests are made depending on the phone_number and email that are submitted. I'd like to see these conditionals in the subscribeUser function covered. For example the case for email consent if we receive a 400 with the response indicating an invalid phone number that we should retry the consent request without the phone number. There should be a test verifying that this request is made twice given the 400 API response. Responses from the API can be mocked but we should be testing that requests are made as expected with the correct arguments and that logging occurs as expected where relevant. Let me know if I need to clarify this, happy to jump on a quick call to discuss! — Reply to this email directly, view it on GitHub <#35 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASLFA3R6OQPRBS4P5XT5I33XRGWINANCNFSM6AAAAAA2PEJ72Y> . You are receiving this because you were mentioned.Message ID: ***@***.***>