Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MockWebServerExtension constructor that accepts a server customizer #561

Merged
merged 2 commits into from
Feb 8, 2025
Merged

Add MockWebServerExtension constructor that accepts a server customizer #561

merged 2 commits into from
Feb 8, 2025

Conversation

sleberknight
Copy link
Member

  • Add one-arg constructor that accepts a Consumer.
  • Throw IllegalArgumentException if the serverCustomizer argument is null.
  • Reorganize the constructor tests and add new test for new constructor.

Related to #547, #555, #556

@sleberknight
Add MockWebServerExtension constructor that accepts a server customizer
a3e3d70 
* Add one-arg constructor that accepts a Consumer<MockWebServer>.
* Throw IllegalArgumentException if the serverCustomizer argument
  is null.
* Reorganize the constructor tests and add new test for new constructor.

Related to #547, #555, #556
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Feb 8, 2025
@sleberknight sleberknight added this to the 3.9.0 milestone Feb 8, 2025
@sleberknight sleberknight self-assigned this Feb 8, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sleberknight sleberknight requested a review from dsingley February 8, 2025 04:48
@sleberknight sleberknight merged commit b841d39 into main Feb 8, 2025
6 checks passed
@sleberknight sleberknight deleted the new-MockWebServerExtension-ctor-with-server-customizer branch February 8, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsingley dsingley dsingley approved these changes

Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sleberknight @dsingley