MockWebServerExtension argument checking, Javadocs, etc. #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add more Javadocs to MockWebServerExtension * Make uri() a "real" method (not Lombok generated) and check that the URI has been assigned. Throw IllegalStateException if it has not been assigned yet. * Add argument checking to uri(path) * Change uri(path) to check that the URI is assigned, and throw IllegalStateException like uri() does when it is not yet assigned. * Add a dedicated test. Previously, this extension was tested indirectly via other tests, which did not include argument and state checking, etc. Related to #547, #555, #556
sleberknight
added
the
enhancement
This was
linked to
issues
Feb 8, 2025
|
dsingley
approved these changes
Feb 8, 2025
sleberknight
deleted the
arg-checking-and-cleanup-of-MockWebServerExtension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #547, #555, #556