⬆️ version: Updated ffpyplayer version and url

[FilipeMarch]

Updated the ffpyplayer version from 4.3.2 (2020) to the latest release (2023). Also updated the url.

I'm already using the version ffpyplayer 4.4.0 on computer and on my phone (on my Kivy app), and it works fine on both.

[DexerBR]

I left one suggestion.

[misl6]

Hi @FilipeMarch and @DexerBR !

Actually https://github.com/matham/ffpyplayer/archive/{version}.zip format gives the user more control without the need of specifying a custom URL that https://github.com/matham/ffpyplayer/archive/refs/tags/v{version}.zip gives not.

As an example:
ffpyplayer==master, ffpyplayer==c3e721f0379eca393c8d1796ff3808157f4a37d3

This (version pinning, maybe being consistent with PyPi packages) is something I think should be improved in the future, but in order to avoid breakages for people targeting ==master on their buildozer.spec files, can we switch back to the previous format?

[DexerBR]

Hi @misl6!

I understand your point, but https://github.com/matham/ffpyplayer/archive/4.4.0.zip is returning a 404: Not Found, that's because it needs the v (https://github.com/matham/ffpyplayer/archive/v4.4.0.zip). How to get around this, taking into account what you mentioned?

[misl6]

Hi @FilipeMarch and @DexerBR

We had a very similar issue and discussion here: https://github.com/kivy/kivy-ios/pull/716/files

Then, we decided to keep the v into the version parameter, and not in the URL, so a user can potentially target the master.zip without any issue.

[DexerBR]

Hi @FilipeMarch and @DexerBR

We had a very similar issue and discussion here: https://github.com/kivy/kivy-ios/pull/716/files

Then, we decided to keep the v into the version parameter, and not in the URL, so a user can potentially target the master.zip without any issue.

Hi @misl6! So it seems ok to me! But perhaps in the future it will be worth dealing with version numbers without the v prefix, or maybe document the behavior.

[misl6]

Hi @FilipeMarch !

Can you change the code as discussed with @DexerBR ?

[misl6]

Hi @FilipeMarch ,

Are you still interested in getting this PR merged? 🥰

If yes, can you please address the requested changes and rebase on top of latest develop branch?

[FilipeMarch]

Hi @FilipeMarch ,

Are you still interested in getting this PR merged? 🥰

If yes, can you please address the requested changes and rebase on top of latest develop branch?

Yes, I had forgotten this PR for a long time, I will make the requested changes, give me some time

[DexerBR]

@FilipeMarch By the way, I think there is a newer version of ffpyplayer now

[elise1983]

Hey can we see this get merged please? Really needing a newer version of ffpyplayer in the python-for-android recipes, it has stopped working since SDL and Kivy recipes were updated. I'm choosing not to specifiy versioning in my spec so I'm relying on the master recipes being up to date. Thanks!

[FilipeMarch]

I'm sorry for being so slow on this, I'll try to see it this weekend

[elise1983]

When this gets updated can we look at the dependencies being updated too? FFMpeg etc?

[AndreMiras]

Hi @FilipeMarch
We're almost there, we probably just need the rebase, it's fine if we don't bump the version again if you don't have time to test it.
All we need is a rebase.

git pull --rebase upstream develop # assuming the remote is called upstream

Ping me on Discord if you need guidance on the Git side.

[nheffelman]

can anyone please show me a buildozer.spec that lists ffpyplayer as a requirement and how to include recipes for it. I cannot find any buildozer.spec file that includes a recipe anywhere.