Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor detail map view, update OpenLayers and remember image zoom #6236

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

thomaslow
Copy link
Collaborator

@thomaslow thomaslow commented Sep 27, 2024

This pull request refactors the ol_custom.js Javascript code, updates its OpenLayers dependency from v5.2.0 to v6.14.1 and fixes #5796. New features include:

  • position, zoom and rotation of images are remembered when selecting new images
  • a new control button allows to scale the image to best fit the current available space
  • the OpenLayer constraints feature is enabled, such that the image can never be moved outside of the viewport
  • Integration tests of zoom in, zoom out, set north, rotate left, rotate right and zoom reset buttons

Tested with Firefox, Chrome and Android Tablet (touch gestures).

Demo:

2024-09-27.13-45-26.mp4

@solth
Copy link
Member

solth commented Oct 1, 2024

@thomaslow Please rebase against current master to avoid failing builds caused by broken Selenium tests!

@thomaslow thomaslow force-pushed the refactor-detail-map-and-fix-5796 branch from ec526ba to 0852f11 Compare October 1, 2024 08:49
@thomaslow thomaslow marked this pull request as ready for review October 1, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata editor: Keep size of image in detail view
2 participants