Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update generic_client.go: resolve the -include-path parameter does not support the PB IDL type. #19

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

xuanskyer
Copy link
Contributor

@xuanskyer xuanskyer commented Dec 7, 2024

Resolve the -include-path parameter does not support the PB IDL type.

What type of PR is this?

fix: A bug fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Which issue(s) this PR fixes:

Fixes #18

(optional) The PR that updates user documentation:

add Conf.IncludePath... param
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xuanskyer

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xuanskyer
Copy link
Contributor Author

@Zzhiter @HeyJavaBean pls help review this PR, tks!

@Zzhiter Zzhiter merged commit 0ec147c into kitex-contrib:main Dec 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants