Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Enhancement of kitexcall‘s warning info for MultiService Support #8

Open
Zzhiter opened this issue Jun 5, 2024 · 1 comment
Labels
easy enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Zzhiter
Copy link
Collaborator

Zzhiter commented Jun 5, 2024

When the server is running in MultiService mode, it is necessary to manually specify the IDLServiceName and to designate a transport protocol as TTHeader or TTHeaderFramed. However, there is a gap because users may neglect to specify a compatible transport protocol such as TTHeader or TTHeaderFramed.

The possible error message is as follows:

[ServerError]: RPC call failed: missing method: Method1 in service

But our error message does not provide an appropriate hint to tell the user to manually specify a transport protocol like TTHeader or TTHeaderFramed.

We can add a warning to stderr for cases where the IDLServiceName is specified, and server is in MultiService mode(This may be guessed by error message below, since when user specifiy the IDLServiceName, it is possible that server in not in MultiService mode) but a transport capable of carrying it is not specified, giving users a clear prompt.

@Zzhiter Zzhiter added good first issue Good for newcomers help wanted Extra attention is needed easy labels Jun 5, 2024
@Zzhiter
Copy link
Collaborator Author

Zzhiter commented Jun 5, 2024

To see the demo, try this: https://github.com/a631807682/kitexcall-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant