Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VLT compat #5

Merged
merged 4 commits into from
Dec 29, 2023
Merged

VLT compat #5

merged 4 commits into from
Dec 29, 2023

Conversation

jackahl
Copy link
Member

@jackahl jackahl commented Dec 28, 2023

No description provided.

@jackahl jackahl requested a review from sneridagh December 29, 2023 12:18
Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see comments

@include default-container-width();
// Adding 2 * 10px (one for each side) we force the container to extend the value of
// the gutter to match the other blocks margin.
max-width: calc(var(--default-container-width) + 2 * 10px);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there not a mixin that does it? adjustMarginsToContainer I think it's named.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackahl jackahl merged commit a59dff8 into main Dec 29, 2023
4 checks passed
@jackahl jackahl deleted the VLT-compat branch January 4, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants