Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Backlog Submission Date to Latest Result Date #81

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

T3C42
Copy link
Contributor

@T3C42 T3C42 commented Nov 30, 2024

The backlog currently shows the date the submission was uploaded.
It would be more helpful to display the last result modification date to quickly find previously edited results.

The order of display remains the artemis order.

@T3C42 T3C42 requested review from CDaut and a team as code owners November 30, 2024 14:45
@Feuermagier
Copy link
Collaborator

Feuermagier commented Nov 30, 2024

Note that the benefit of the submission order is that it's the same ordering as in Artemis (that's why I implemented it Iike this to begin with :P). This can sometimes be very handy, though I see that it's not the most intuitive in Intelligrade. Ideally we would have an option for both.

@dfuchss
Copy link
Member

dfuchss commented Nov 30, 2024

@T3C42 please run once ./gradlew spotlessApply :)

@dfuchss
Copy link
Member

dfuchss commented Nov 30, 2024

Note that the benefit of the submission order is that it's the same ordering as in Artemis (that's why I implemented it Iike this to begin with :P). This can sometimes be very handy, though I see that it's not the most intuitive in Intelligrade. Ideally we would have an option for both.

Isn't the PR just about the date label in the list 😂 ?

@CDaut
Copy link
Collaborator

CDaut commented Nov 30, 2024

This PR doesn't seem to change much, so if noone complains down the line it should be fine. Please run spotlessApply.

@T3C42
Copy link
Contributor Author

T3C42 commented Nov 30, 2024

Note that the benefit of the submission order is that it's the same ordering as in Artemis (that's why I implemented it Iike this to begin with :P). This can sometimes be very handy, though I see that it's not the most intuitive in Intelligrade. Ideally we would have an option for both.

The change should not affect the order if I am not mistaken.

@Feuermagier
Copy link
Collaborator

Oh sorry, I didn't check the code and misunderstood the PR title :D

@Feuermagier
Copy link
Collaborator

Did you test the change as a non-instructor (i.e. only tutor/TA)?

@dfuchss
Copy link
Member

dfuchss commented Nov 30, 2024

If spotless apply does not change anything, you can locally comment the line with ratchet (build.gradle) ; I just have seen that you committed to origin/main of your fork :D

@T3C42
Copy link
Contributor Author

T3C42 commented Nov 30, 2024

If spotless apply does not change anything, you can locally comment the line with ratchet (build.gradle) ; I just have seen that you committed to origin/main of your fork :D

Spotless apply in fact did not change anything. I'm not sure how to use ratchet.

Edit: Got it. Updating the PR now.

@T3C42
Copy link
Contributor Author

T3C42 commented Nov 30, 2024

Did you test the change as a non-instructor (i.e. only tutor/TA)?

I tested in my current Role

@dfuchss dfuchss merged commit 1dd3400 into kit-sdq:main Nov 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants