feat: KeyboardToolbar.Exclude
#881
Conversation
kirillzyusko
added
enhancement
kirillzyusko
force-pushed
the
feat/keyboard-toolbar-exclude
branch
from
0c409b6 to
cf36b65
Compare
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
📊 Package size report
|
|
A slightly better approach would be to introduce a component: <KeyboardToolbar.Group name="group1" discoverable>
</KeyboardToolbar.Group>In this what effectively we would do is to split inputs in group under their own names. Such approach is more flexible in my inderstanding, because if we would have tab-view written in pure JS:
Then we in last input of tab 1 we could easily go to the second tab. If we would use I think a new API should offer better extendability for future goals. |
| @@ -91,7 +92,7 @@ object ViewHierarchyNavigator { | |||
|
|
|||
| if (isValidTextInput(child)) { | |||
| result = child as EditText | |||
| } else if (child is ViewGroup) { | |||
| } else if (child is ViewGroup && child !is KeyboardToolbarExcludeReactViewGroup) { | |||
There was a problem hiding this comment.
this check repeats twice, would it be better to use helper function for this?
| @@ -91,6 +91,8 @@ public class ViewHierarchyNavigator: NSObject { | |||
| return validTextInput | |||
| } | |||
|
|
|||
| guard String(describing: type(of: view)) != "KeyboardToolbarExcludeView" else { return nil } | |||
There was a problem hiding this comment.
- is it possible to use instance check instead of comparing two strings?
- it repeats twice
There was a problem hiding this comment.
Copilot reviewed 6 out of 16 changed files in this pull request and generated 1 comment.
Files not reviewed (10)
- android/src/base/java/com/reactnativekeyboardcontroller/KeyboardControllerPackage.kt: Language not supported
- android/src/main/java/com/reactnativekeyboardcontroller/managers/KeyboardToolbarExcludeViewManagerImpl.kt: Language not supported
- android/src/main/java/com/reactnativekeyboardcontroller/traversal/ViewHierarchyNavigator.kt: Language not supported
- android/src/main/java/com/reactnativekeyboardcontroller/views/KeyboardToolbarExcludeReactViewGroup.kt: Language not supported
- android/src/paper/java/com/reactnativekeyboardcontroller/KeyboardToolbarExcludeViewManager.kt: Language not supported
- android/src/turbo/java/com/reactnativekeyboardcontroller/KeyboardControllerPackage.kt: Language not supported
- docs/docs/api/components/keyboard-toolbar/index.mdx: Language not supported
- ios/traversal/ViewHierarchyNavigator.swift: Language not supported
- ios/views/KeyboardToolbarExcludeViewManager.h: Language not supported
- ios/views/KeyboardToolbarExcludeViewManager.mm: Language not supported
| @@ -60,3 +60,5 @@ export const KeyboardGestureArea: React.FC<KeyboardGestureAreaProps> = | |||
| : ({ children }: KeyboardGestureAreaProps) => children; | |||
| export const RCTOverKeyboardView: React.FC<OverKeyboardViewProps> = | |||
| require("./specs/OverKeyboardViewNativeComponent").default; | |||
| export const RCTKeyboardToolbarExcludeView: React.FC<OverKeyboardViewProps> = | |||
There was a problem hiding this comment.
The type for RCTKeyboardToolbarExcludeView should use KeyboardToolbarExcludeViewProps instead of OverKeyboardViewProps for consistency with the rest of the bindings.
| export const RCTKeyboardToolbarExcludeView: React.FC<OverKeyboardViewProps> = | |
| export const RCTKeyboardToolbarExcludeView: React.FC<KeyboardToolbarExcludeViewProps> = |
Copilot uses AI. Check for mistakes.
📜 Description
💡 Motivation and Context
Closes #470
📢 Changelog
JS
iOS
Android
🤔 How Has This Been Tested?
📸 Screenshots (if appropriate):
📝 Checklist