-
-
Notifications
You must be signed in to change notification settings - Fork 100
fix: rewrite onTextChanged
to onSelectionChanged
event handler in KeyboardAwareScrollView
#546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kirillzyusko
wants to merge
9
commits into
main
Choose a base branch
from
fix/keyboard-aware-scroll-view-rewrite-text-changed-to-text-selection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report
|
cfe7be3
to
8783c80
Compare
97d5f90
to
0d2bc42
Compare
d8d8f34
to
f802462
Compare
f802462
to
5e6ad22
Compare
… `KeyboardAwareScrollView`
5e6ad22
to
574ca82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐛 bug
Something isn't working
KeyboardAwareScrollView 📜
Anything related to KeyboardAwareScrollView component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
looks like<-- revert assetsuseAnimatedReaction
on iOS doesn't work (FirstInputGrown
image has changed);Android - when scroll back disabled it still scrollsAndroid - when we type1
we still have the same image as before - theoretically padding should be reduced.flaky Android scrolling<- fixed in e2eflaky<- fixed viaFirstInputGrown
clamp
Android - TextInput after text change too close to keyboarduseAnimatedReaction
and we scroll based onlayout
📜 Description
💡 Motivation and Context
Closes #512
📢 Changelog
JS
iOS
Android
🤔 How Has This Been Tested?
📸 Screenshots (if appropriate):
📝 Checklist