Allow users to fill out forms as GUEST and send email responses #870
Conversation
Isti01
changed the title
| @@ -67,21 +73,22 @@ open class FormService( | |||
| if (form.availableUntil < now) | |||
| return FormView(status = FormStatus.TOO_LATE) | |||
|
|
|||
| if (form.allowedGroups.isNotBlank() && userRepository.findById(user.id) | |||
| if (user?.id != null && form.allowedGroups.isNotBlank() && userRepository.findById(user.id) | |||
There was a problem hiding this comment.
This probably works this way too, but I would probably only check on the user, not the id of it.
| } else { | ||
| responseRepository.findByFormIdAndSubmitterUserId(form.id, user.id).orElse(null) | ||
| user?.id?.let { responseRepository.findByFormIdAndSubmitterUserId(form.id, it).getOrNull() } |
There was a problem hiding this comment.
Same here, this probably works just fine, but I don't think we need to check both the user and the id of the user.
By the way, will the submissionEntity default to null if the user is null?
There was a problem hiding this comment.
Passing null to an SQL query has a very different meaning than skipping the query if the parameter is null
|
One issue I see is that the A few ideas on how this could be handled:
|
| val form = formRepository.findAllByUrl(path).getOrNull(0) | ||
| ?: return FormView(status = FormStatus.NOT_FOUND) | ||
|
|
||
| if ((form.minRole.value > user.role.value || form.maxRole.value < user.role.value) && !user.role.isAdmin) | ||
| val role = user?.role ?: RoleType.GUEST |
There was a problem hiding this comment.
Just an idea:
We could have an UnauthenticatedUser : CmschUser instead of null for representing unauthenticated users, and then these null-checks wouldn't be needed. This would require making most of the attributes on CmschUser nullable, so might not be worth it
There was a problem hiding this comment.
I like it. I think it would improve the codebase. But it would be a part of a major, bigger scope refactor in my opinion
| } | ||
|
|
||
|
|
||
| private fun getEmailForConfirmation( |
There was a problem hiding this comment.
| private fun getEmailForConfirmation( | |
| private fun getEmailAddressForConfirmation( |
…lling out templates
Isti01
force-pushed
the
feature/work-on-admission
branch
from
bd3a594 to
3df4629
Compare
closes #859