This repository has been archived by the owner on May 14, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Kinirr #79
Open
shahriyar9839
wants to merge
63
commits into
kinecosystem:master
Choose a base branch
from
shahriyar9839:kinirr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Kinirr #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. include tests(uncompleted yet. 2. getTransactionBuilder methods and TransactionBuilder class 3. Refactor Transaction class. 4. move 'addAppIdToMemo' method to utils class 5. increase timeout for the account creation listener in the sample app onboarding class
1. add more tests(uncompleted yet). 2. Add support for testing final class with mockito 3. fix the bug in which when decode a transaction then it was multiple the fee by num of operations again 4. format TransactionSenderTest 5. Add Transaction tests
…wrong message in case of more then one operation. 2. Add ManageDataOperation to the integration linkAccount test.
# Conflicts: # kin-sdk/kin-sdk-lib/src/androidTest/kotlin/kin/sdk/FakeKinOnBoard.kt # kin-sdk/kin-sdk-lib/src/androidTest/kotlin/kin/sdk/KinAccountIntegrationTest.kt # kin-sdk/kin-sdk-lib/src/main/java/kin/sdk/Transaction.java
# Conflicts: # kin-backup-and-restore/kin-backup-and-restore-sample/src/main/java/kin/backupandrestore/sample/AccountCreator.java # kin-sdk/kin-sdk-lib/src/androidTest/java/kin/sdk/IntegConsts.java # kin-sdk/kin-sdk-sample/src/main/java/sdk/sample/OnBoarding.java
…olled account and master account
…ailed with IOException
…om the constructor.
2. Move the validate memo to Utils 3. Fix the tests because of transaction constructor change
…e used internally and not be added by the client again.
…ansaction. 2. Add docs and change readme according to the new naming of some methods. 3. Fix the decode transaction so it will return PaymentTransaction only if there was only one payment operation. Also add tests for this method.
Added all the new API methods
…necosystem/kin-sdk-android into DP-492_one_wallet_account_linking_api
…he get prefix remove from previous commit.
…y to test the feature).
…telistableTransaction class
…atedBalanceSync in order for developers to get their aggregated balance even if there current account is not the master. Also added tests.
…unts. Will added them back in one wallet phase 2 and only internally.
# Conflicts: # .travis.yml # kin-backup-and-restore/kin-backup-and-restore-lib/src/androidTest/java/kin/backupandrestore/qr/QRFileUriHandlerImplTest.java # kin-backup-and-restore/kin-backup-and-restore-lib/src/androidTest/java/kin/backupandrestore/qr/TestUtils.java # kin-backup-and-restore/kin-backup-and-restore-lib/src/main/java/kin/backupandrestore/restore/view/RestoreEnterPasswordFragment.java # kin-backup-and-restore/kin-backup-and-restore-lib/src/main/java/kin/backupandrestore/widget/PasswordEditText.java # kin-sdk/kin-sdk-lib/src/androidTest/java/kin/sdk/IntegConsts.java # kin-sdk/kin-sdk-lib/src/androidTest/java/kin/sdk/WhitelistServiceForTest.java # kin-sdk/kin-sdk-lib/src/androidTest/kotlin/kin/sdk/KinAccountIntegrationTest.kt # kin-sdk/kin-sdk-lib/src/main/java/kin/sdk/TransactionSender.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main purpose (bug/feature/enhancement + description)
Technical details
Tests (Unit/Integ)
Documentation (Source/readme.md)