Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved ReadMe.md and added fil phone_number_component #64

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

Patsy101
Copy link
Contributor

@Patsy101 Patsy101 commented Feb 25, 2024

Explain your changes

Hi @evgenyk and @DaveOrDead,

I've made some updates to the Readme.md file and added some translated files in fil (fil/auth.json).

Feel free to provide any feedback. I felt it was necessary to enhance the user experience for contributors and prevent potential misuse of language contributions. By requesting translators to briefly explain their experiences with translations, we aim to add credibility to the contributions.

Thank you!

PS ** I notice Dave added more schema structure, im deciding whether adding a live progress bar on readme file for each translated language(e.g. sv/auth.json)
image
**

Checklist

Checklist
✅I have read the “Pull requests” section in the contributing guidelines.
✅I agree to the terms within the code of conduct.

@DaveOrDead
Copy link
Member

Champion thanks @Patsy101 - nice one for the readme updates! The progress bar sounds like an awesome idea

@DaveOrDead DaveOrDead merged commit 63322e1 into kinde-oss:main Feb 28, 2024
2 checks passed
@Patsy101
Copy link
Contributor Author

Hi @DaveOrDead

I recently got a job at Windcave after months of job hunting..... tough times..... I hate to tell this but it seems i can't do the live progress bars because of work commitments but im more than happy to help any potential contributors in the future

Kind Regards,
Patrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants