Merge pull request theochem#69 from tovrstra/more_whitespace

More sensitive whitespace linter

cardboardlint/linter_whitespace.py

@@ -60,13 +60,23 @@ def run_whitespace(_config, filenames):
             line = None
             lineno = -1
             for lineno, line in enumerate(f):
+                # Check for tabs
                 charno = line.find('\t')
                 if charno >= 0:
                     messages.append(Message(filename, lineno + 1, charno + 1, 'tab'))
+                # Check for carriage return
+                charno = line.find('\r')
+                if charno >= 0:
+                    messages.append(Message(filename, lineno + 1, charno + 1, 'carriage return'))
+                # Check for trailing whitespace
                 if line[:-1] != line.rstrip():
                     messages.append(Message(filename, lineno + 1, None, 'trailing whitespace'))
-            if line is not None and len(line.strip()) == 0:
-                messages.append(Message(filename, lineno + 1, None, 'trailing empty line'))
+            # Perform some checks on the last line
+            if line is not None:
+                if len(line.strip()) == 0:
+                    messages.append(Message(filename, lineno + 1, None, 'trailing empty line'))
+                if not line.endswith("\n"):
+                    messages.append(Message(filename, lineno + 1, None, 'last line missing \\n'))
     return messages
 
 

tools/example/README.rst

@@ -1,2 +1,3 @@
 This directory contains a simple example for all supported linters. This example is used
 to run through all code at least once.
+Hello

tools/example/broken.yaml

@@ -1,4 +1,4 @@
-- foo: bar
-  - foobar
-
-egg
+- foo: bar
+  - foobar
+
+egg