From 5aacc99ad46beed68d0d4d1902d388a7df96fd84 Mon Sep 17 00:00:00 2001 From: Karl Heinz Marbaise Date: Wed, 6 May 2020 18:55:09 +0200 Subject: [PATCH] Fixed #80 - Error message "Log4j2 could not find a logging implementation" --- .../usersguide/release-notes/_release-notes-0.6.0.adoc | 4 ++++ itf-examples/pom.xml | 4 ---- itf-jupiter-extension/pom.xml | 4 ---- .../com/soebes/itf/jupiter/extension/MavenITExtension.java | 7 +------ .../com/soebes/itf/jupiter/extension/MavenLocator.java | 7 ------- .../com/soebes/itf/jupiter/extension/MavenVersion.java | 4 ---- itf-maven-plugin/pom.xml | 4 ---- pom.xml | 7 ------- 8 files changed, 5 insertions(+), 36 deletions(-) diff --git a/itf-documentation/src/main/asciidoc/usersguide/release-notes/_release-notes-0.6.0.adoc b/itf-documentation/src/main/asciidoc/usersguide/release-notes/_release-notes-0.6.0.adoc index 246bf88016..95a3b4329b 100644 --- a/itf-documentation/src/main/asciidoc/usersguide/release-notes/_release-notes-0.6.0.adoc +++ b/itf-documentation/src/main/asciidoc/usersguide/release-notes/_release-notes-0.6.0.adoc @@ -26,6 +26,7 @@ :issue-76: https://github.com/khmarbaise/maven-it-extension/issues/76[Fixed #76] :issue-77: https://github.com/khmarbaise/maven-it-extension/issues/77[Fixed #77] :issue-78: https://github.com/khmarbaise/maven-it-extension/issues/78[Fixed #78] +:issue-80: https://github.com/khmarbaise/maven-it-extension/issues/80[Fixed #80] :issue-81: https://github.com/khmarbaise/maven-it-extension/issues/81[Fixed #81] :issue-84: https://github.com/khmarbaise/maven-it-extension/issues/84[Fixed #84] @@ -48,12 +49,15 @@ * With {issue-68} - we have renamed the `@MavenIT` annotation into `@MavenJupiterExtension` to make the intention more clear. + * With {issue-80} - We have removed the previously needed log4j dependencies at all. In testing + projects there is no need anymore in adding `log4j-core` dependency. *Reporters of this release* * Roland Weisleder ** {issue-76} - "Getting started" is hard to find. ** {issue-77} - Code in section "Configuration in Maven" (user guide) should be copy-pastable + ** {issue-80} - Error message "Log4j2 could not find a logging implementation" *Contributors of this release* diff --git a/itf-examples/pom.xml b/itf-examples/pom.xml index 2a4bb2fb47..9cac8ae6af 100644 --- a/itf-examples/pom.xml +++ b/itf-examples/pom.xml @@ -56,10 +56,6 @@ test - - org.apache.logging.log4j - log4j-core - diff --git a/itf-jupiter-extension/pom.xml b/itf-jupiter-extension/pom.xml index a614bf71e1..86c75ea950 100644 --- a/itf-jupiter-extension/pom.xml +++ b/itf-jupiter-extension/pom.xml @@ -91,10 +91,6 @@ commons-io commons-io - - org.apache.logging.log4j - log4j-api - \ No newline at end of file diff --git a/itf-jupiter-extension/src/main/java/com/soebes/itf/jupiter/extension/MavenITExtension.java b/itf-jupiter-extension/src/main/java/com/soebes/itf/jupiter/extension/MavenITExtension.java index 9b73a05fb4..dd9d9fb51b 100644 --- a/itf-jupiter-extension/src/main/java/com/soebes/itf/jupiter/extension/MavenITExtension.java +++ b/itf-jupiter-extension/src/main/java/com/soebes/itf/jupiter/extension/MavenITExtension.java @@ -26,8 +26,6 @@ import com.soebes.itf.jupiter.maven.MavenProjectResult; import com.soebes.itf.jupiter.maven.ProjectHelper; import org.apache.commons.io.FileUtils; -import org.apache.logging.log4j.LogManager; -import org.apache.logging.log4j.Logger; import org.apache.maven.model.Model; import org.codehaus.plexus.util.xml.pull.XmlPullParserException; import org.junit.jupiter.api.extension.BeforeEachCallback; @@ -68,8 +66,6 @@ public class MavenITExtension implements BeforeEachCallback, ParameterResolver, BeforeTestExecutionCallback, InvocationInterceptor { - private static final Logger LOGGER = LogManager.getLogger(); - @Override public void beforeEach(ExtensionContext context) { Class testClass = context.getTestClass() @@ -172,8 +168,7 @@ public void beforeTestExecution(ExtensionContext context) Optional mvnLocation = new MavenLocator().findMvn(); if (!mvnLocation.isPresent()) { - LOGGER.error(() -> String.format("We could not find the maven executable `mvn` somewhere")); - throw new IllegalStateException("We can't find maven executable anywhere."); + throw new IllegalStateException(String.format("We could not find the maven executable `mvn` somewhere")); } ApplicationExecutor mavenExecutor = new ApplicationExecutor(directoryResolverResult.getProjectDirectory(), diff --git a/itf-jupiter-extension/src/main/java/com/soebes/itf/jupiter/extension/MavenLocator.java b/itf-jupiter-extension/src/main/java/com/soebes/itf/jupiter/extension/MavenLocator.java index 0cf829d9c0..24d5f07ad8 100644 --- a/itf-jupiter-extension/src/main/java/com/soebes/itf/jupiter/extension/MavenLocator.java +++ b/itf-jupiter-extension/src/main/java/com/soebes/itf/jupiter/extension/MavenLocator.java @@ -19,8 +19,6 @@ * under the License. */ -import org.apache.logging.log4j.LogManager; -import org.apache.logging.log4j.Logger; import org.junit.jupiter.api.condition.OS; import java.io.File; @@ -46,7 +44,6 @@ * but they also lack the support of toFile(). */ class MavenLocator { - private static final Logger LOGGER = LogManager.getLogger(); private static final String MAVEN_HOME = "maven.home"; @@ -116,7 +113,6 @@ Optional checkExecutableViaPathEnvironment() { for (String item : split) { Optional mvnLocation = checkExecutable(Paths.get(item)); if (mvnLocation.isPresent()) { - LOGGER.debug(() -> String.format("mvnLocation: '%s'", mvnLocation)); return mvnLocation; } } @@ -128,9 +124,6 @@ Optional findMvn() { if (s.isPresent()) { Optional file = checkExecutable(Paths.get(s.get(), "bin")); if (!file.isPresent()) { - LOGGER.error(() -> String.format( - "We couldn't find an mvn executable via maven.home system property: '%s'", - System.getProperty(MAVEN_HOME))); return Optional.empty(); } return checkExecutableViaPathEnvironment(); diff --git a/itf-jupiter-extension/src/main/java/com/soebes/itf/jupiter/extension/MavenVersion.java b/itf-jupiter-extension/src/main/java/com/soebes/itf/jupiter/extension/MavenVersion.java index 381cc45df0..85f0654802 100644 --- a/itf-jupiter-extension/src/main/java/com/soebes/itf/jupiter/extension/MavenVersion.java +++ b/itf-jupiter-extension/src/main/java/com/soebes/itf/jupiter/extension/MavenVersion.java @@ -19,8 +19,6 @@ * under the License. */ -import org.apache.logging.log4j.LogManager; -import org.apache.logging.log4j.Logger; import org.apiguardian.api.API; import java.util.stream.Stream; @@ -49,8 +47,6 @@ public enum MavenVersion { M3_6_2("3.6.2"), M3_6_3("3.6.3"); - private static final Logger LOGGER = LogManager.getLogger(); - private static final MavenVersion CURRENT_MAVEN_VERSION = determineCurrentVersion(); private final String versionString; diff --git a/itf-maven-plugin/pom.xml b/itf-maven-plugin/pom.xml index 322a3439d4..7b8421f833 100644 --- a/itf-maven-plugin/pom.xml +++ b/itf-maven-plugin/pom.xml @@ -55,10 +55,6 @@ 3.6.0 provided - - org.apache.logging.log4j - log4j-core - org.junit.jupiter junit-jupiter-engine diff --git a/pom.xml b/pom.xml index d3a7824e99..92c40b30f1 100644 --- a/pom.xml +++ b/pom.xml @@ -70,13 +70,6 @@ - - org.apache.logging.log4j - log4j-bom - 2.13.2 - pom - import - org.junit junit-bom