Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(burushos.bsk-latn.burushaski): make name consistent and apply version number #298

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix(burushos.bsk-latn.burushaski): make name consistent and apply version number #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions release/burushos/burusho.bsk-latn.burushaski/burusho.bsk-latn.burushaski.model_info
View file
Open in desktop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.model_info files should no longer be committed to the repository

This file was deleted.

0 ...os/burusho.bsk-latn.burushaski/HISTORY.md → ...s/burushos.bsk-latn.burushaski/HISTORY.md
View file
Open in desktop
File renamed without changes.
0 ...os/burusho.bsk-latn.burushaski/LICENSE.md → ...s/burushos.bsk-latn.burushaski/LICENSE.md
View file
Open in desktop
File renamed without changes.
0 ...hos/burusho.bsk-latn.burushaski/README.md → ...os/burushos.bsk-latn.burushaski/README.md
View file
Open in desktop
File renamed without changes.
0 ...urushaski/burusho.bsk-latn.burushaski.kpj → ...rushaski/burushos.bsk-latn.burushaski.kpj
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...rce/burusho.bsk-latn.burushaski.model.kps → ...ce/burushos.bsk-latn.burushaski.model.kps
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@
<Name URL="">Burushaski</Name>
<Copyright URL="">Copyright © Burusho</Copyright>
<Author URL="">Burusho</Author>
Copy link
Contributor

@darcywong00 darcywong00 Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe more sadness.
If the author name is "Burusho", should the parent folder change from "burushos" to "burusho"? And then changing the other model (burushos.bsk.burushaski) to match?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted to match the existing model which has already been widely deployed. It's much messier to go the other way, and not worth the pain IMHO.

<Version URL=""></Version>
<Version URL="">1.0.0</Version>
<Description URL="">This is lexical model for Burushaski Latin Script.</Description>
</Info>
<Files>
<File>
<Name>..\build\burusho.bsk-latn.burushaski.model.js</Name>
<Name>..\build\burushos.bsk-latn.burushaski.model.js</Name>
<Description></Description>
<CopyLocation>0</CopyLocation>
<FileType>.js</FileType>
Expand Down Expand Up @@ -53,7 +53,7 @@
<LexicalModels>
<LexicalModel>
<Name>Burushaski</Name>
<ID>burusho.bsk-latn.burushaski</ID>
<ID>burushos.bsk-latn.burushaski</ID>
<Languages>
<Language ID="bsk-Latn">Burushaski</Language>
</Languages>
Expand Down
0 ...urce/burusho.bsk-latn.burushaski.model.ts → ...rce/burushos.bsk-latn.burushaski.model.ts
View file
Open in desktop
File renamed without changes.
0 ...sho.bsk-latn.burushaski/source/readme.htm → ...hos.bsk-latn.burushaski/source/readme.htm
View file
Open in desktop
File renamed without changes.
0 ...ho.bsk-latn.burushaski/source/welcome.htm → ...os.bsk-latn.burushaski/source/welcome.htm
View file
Open in desktop
File renamed without changes.
0 ...o.bsk-latn.burushaski/source/wordlist.tsv → ...s.bsk-latn.burushaski/source/wordlist.tsv
View file
Open in desktop
File renamed without changes.